Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monitoring grids data for multishop #14991

Merged
merged 3 commits into from Aug 26, 2019

Conversation

@zuk3975
Copy link
Contributor

commented Aug 5, 2019

Questions Answers
Branch? develop
Description? When multiple shops exists, but context is single shop - most of migrated Monitoring lists where not considering the shop context id when getting data.
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? part of #10552
How to test? Use /admin-dev/index.php/sell/catalog/monitoring to see migrated monitoring page. When multiple shops are available, select one of them and make sure that all monitoring grids are showing data just for that shop. When All shops are enabled, grids should contain data for default shop. ⚠️ Actions like edit/delete are not migrated within this PR, because it is highly coupled with product page

This change is Reviewable

@zuk3975 zuk3975 requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 5, 2019

@zuk3975 zuk3975 referenced this pull request Aug 5, 2019
1 of 32 tasks complete

@matks matks added the migration label Aug 16, 2019

@matks matks added this to the 1.7.7.0 milestone Aug 16, 2019

@sarahdib sarahdib self-assigned this Aug 19, 2019

@sarahdib

This comment has been minimized.

Copy link

commented Aug 19, 2019

Hello @zuk3975

  • In migrated page the product appear in the second shop but I created this one only for the first shop

image

image


  • When I search by id there is no result if the id isn't the same. For example if I search 3, 23 need to be in the list

image

image


  • Delete and edit button not working but I think it's normal. Those action aren't migrated yet ?
@zuk3975

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Thanks @sarahdib,

  • I've fixed the first issue with product shown in wrong shop.

  • When I search by id there is no result if the id isn't the same. For example if I search 3, 23 need to be in the list - it is expected behavior, migrated lists filters id by exact value.

  • Delete and edit button not working but I think it's normal. Those action aren't migrated yet - yes, not migrated, so it is normal :)

@zuk3975 zuk3975 force-pushed the zuk3975:fix/monitoring-multi-shop branch from c3321c5 to d5260ee Aug 20, 2019

@sarahdib

This comment has been minimized.

Copy link

commented Aug 20, 2019

Thanks @zuk3975 I'm waiting for a review and I will test it :)

@zuk3975

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Thanks @zuk3975 I'm waiting for a review and I will test it :)

@matks, could you check and also restart travis, please? :)

@matks
matks approved these changes Aug 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Here we go ! 😄

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

PrettyCI is lost 🙄

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

PrettyCI is now happy 😊thank you @mnapoli

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Thank you @zuk3975

@matks matks merged commit b78b23b into PrestaShop:develop Aug 26, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.