Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Catalog > Files and Catalog > Files Edit and create forms #15003

Merged
merged 25 commits into from Dec 13, 2019

Conversation

@RaimondasSapola
Copy link
Contributor

RaimondasSapola commented Aug 6, 2019

Questions Answers
Branch? develop
Description? Catalog > Files and Catalog > Files Edit and create forms
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10551
How to test? Go to /admin-dev/index.php/sell/attachments/new. and /admin-dev/index.php/sell/attachments/{$id}/edit These pages should work as previously. ⚠️ Assets need to be built ⚠️

This change is Reviewable

@RaimondasSapola RaimondasSapola requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 6, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 6, 2019

Hello @RaimondasSapola!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@RaimondasSapola RaimondasSapola changed the title M/files/form Migration Catalog > Files and Catalog > Files Edit and create forms Aug 7, 2019
*#}

{% set enableSidebar = true %}
{% set layoutTitle = 'Add new'|trans({}, 'Admin.Actions') %}

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Aug 7, 2019

Contributor

Add new file instead? It will match this comment and allow harmonize our wordings throughout the software. :-)

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Aug 7, 2019

Contributor

We need to precise the localization though.


{% set enableSidebar = true %}

{% set layoutTitle = 'Editing attachment %name%'|trans({'%name%': attachmentInformation.name|first}, 'Admin.Orderscustomers.Feature') %}

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Aug 7, 2019

Contributor

Where would this wording be displayed? It is not the mere "Edit" button at the right end of each line in the files list, right?

This comment has been minimized.

Copy link
@RaimondasSapola

RaimondasSapola Aug 8, 2019

Author Contributor

It is show as title in edit attachment page and now is changed to Edit: %value% from Admin.Catalog.Feature domain

@RaimondasSapola RaimondasSapola changed the title Migration Catalog > Files and Catalog > Files Edit and create forms [WIP] Migration Catalog > Files and Catalog > Files Edit and create forms Aug 12, 2019
@RaimondasSapola

This comment has been minimized.

Copy link
Contributor Author

RaimondasSapola commented Aug 12, 2019

Edit form should have download attachment button. Waiting for #14864 to be merged with uploaded attachment download backend functionality

@matks matks added the migration label Aug 16, 2019
@matks matks mentioned this pull request Sep 9, 2019
1 of 30 tasks complete
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 7, 2019

@RaimondasSapola I see you almost finished code review feedbacks 😉only missing items:

@RaimondasSapola RaimondasSapola force-pushed the RaimondasSapola:M/Files/Form branch from 9e942f3 to 1557640 Oct 14, 2019
@RaimondasSapola RaimondasSapola force-pushed the RaimondasSapola:M/Files/Form branch from 58cd3dd to ae2a8bc Oct 25, 2019
@RaimondasSapola RaimondasSapola changed the title [WIP] Migration Catalog > Files and Catalog > Files Edit and create forms Migration Catalog > Files and Catalog > Files Edit and create forms Oct 25, 2019
@matks matks force-pushed the RaimondasSapola:M/Files/Form branch from e814312 to 5d27cd8 Dec 13, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 13, 2019

Rebase done, thanks @RaimondasSapola

@matks
matks approved these changes Dec 13, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 13, 2019

Hi @RaimondasSapola , thanks for the fix !

It's all OK now :)

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 13, 2019

Thank you @RaimondasSapola

@matks matks merged commit b67b62f into PrestaShop:develop Dec 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.