Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of Sell > Customer Service > Merchandise Returns page #15022

Merged

Conversation

@rokaszygmantas
Copy link
Contributor

rokaszygmantas commented Aug 7, 2019

Questions Answers
Branch? develop
Description? Migrates Sell > Customer Service > Merchandise Returns page. Page is hidden, accesible via URL: /admin-dev/index.php/sell/customer-service/merchandise-return/. View action in the returns list is not migrated in this PR - will be done in a separate one.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10554
How to test? Compare to legacy controller. ⚠️ rebuild assets before testing

This change is Reviewable

@rokaszygmantas

This comment has been minimized.

Copy link
Contributor Author

rokaszygmantas commented Aug 8, 2019

Blocked by #13988
Grid ColorColumn is implemented in orders list and would be reusable in this PR.

@rokaszygmantas rokaszygmantas changed the title Migration of Sell > Customer Service > Merchandise Returns page [WIP] Migration of Sell > Customer Service > Merchandise Returns page Aug 8, 2019
@matks matks added the migration label Aug 16, 2019
@rokaszygmantas rokaszygmantas force-pushed the rokaszygmantas:migration/merchandise_returns branch from 35480d0 to d1f3c2a Aug 30, 2019
@rokaszygmantas rokaszygmantas changed the title [WIP] Migration of Sell > Customer Service > Merchandise Returns page Migration of Sell > Customer Service > Merchandise Returns page Aug 30, 2019
@rokaszygmantas rokaszygmantas marked this pull request as ready for review Aug 30, 2019
@rokaszygmantas rokaszygmantas requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 30, 2019
Copy link
Contributor

matks left a comment

Almost perfect 👍 a very small feedback above

@matks matks mentioned this pull request Sep 9, 2019
1 of 31 tasks complete
@zuk3975 zuk3975 force-pushed the rokaszygmantas:migration/merchandise_returns branch from f0fba4c to 5064d33 Sep 23, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Sep 23, 2019

Hello @rokaszygmantas

There is a problem if I search by date only with "From" setup:
https://drive.google.com/file/d/1--ftQBt005n-t70Ljc5hJEzLSHbqpbop/view

same problem if only "To" is setup

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

Cool ! One rebase and we can merge 😄

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Nov 4, 2019
@matks matks dismissed their stale review via 9274cce Nov 6, 2019
@matks matks force-pushed the rokaszygmantas:migration/merchandise_returns branch from 16eb76d to 9274cce Nov 6, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 6, 2019

Rebased, waiting for Travis before merge

@matks
matks approved these changes Nov 6, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 6, 2019

Thank you @rokaszygmantas

@eternoendless eternoendless merged commit 9bd9bf5 into PrestaShop:develop Nov 6, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@rokaszygmantas rokaszygmantas deleted the rokaszygmantas:migration/merchandise_returns branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.