Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming files and test directory - Smoke tests campaign #15024

Conversation

@nesrineabdmouleh
Copy link
Contributor

commented Aug 7, 2019

Questions Answers
Branch? develop
Description? Renaming "test" folder to "campaigns", renaming some folders and classes (Remove "BO_" and "FO_" )
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? npm run smoke-tests

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 7, 2019
nesrine abdmouleh
@nesrineabdmouleh nesrineabdmouleh force-pushed the nesrineabdmouleh:renaming_files_and_test_directory branch from ce0fe03 to 2af3ac8 Aug 7, 2019
Copy link
Contributor

left a comment

LGTM

@matthieu-rolland matthieu-rolland merged commit 7d7e9bb into PrestaShop:develop Aug 7, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks matks added this to the 1.7.7.0 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.