Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in Employee processing #15027

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@gavinkalika
Copy link

commented Aug 7, 2019

Questions Answers
Branch? develop
Description? Typo fix
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? (optional) If this PR fixes an Issue, please write "Fixes #[issue number]" here.
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

Gavin Kalikapersaud
@gavinkalika gavinkalika requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 7, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

Hello @gavinkalika!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@gavinkalika

This comment has been minimized.

Copy link
Author

commented Aug 7, 2019

I don't understand how the build is failing.

My code changes has nothing to do with e2e test "before all" hook:

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@gavinkalika sorry about that, it's a random false positive occurence of our E2E tests
It will be fixed, I re-run travis on your PR to make it pass

@matks
matks approved these changes Aug 12, 2019
@matks matks added this to the 1.7.7.0 milestone Aug 13, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Thank you @gavinkalika the build is fine now 😄

No need for QA as this is a typo fix

@matks matks merged commit b95c22a into PrestaShop:develop Aug 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks matks changed the title Error message typo fix Typo fix in Employee processing Aug 13, 2019
@gavinkalika gavinkalika deleted the gavinkalika:typo-fix branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.