Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpDoc | fix module::updatePosition() param type #15079

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@zalexki
Copy link
Contributor

commented Aug 12, 2019

Questions Answers
Branch? develop
Description? Wrong php doc type
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? use phpstan lvl 5

This change is Reviewable

@zalexki zalexki requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 12, 2019
Copy link
Contributor

left a comment

LGTM

thank you for your contribution @zalexki !

@matthieu-rolland matthieu-rolland merged commit 88db257 into PrestaShop:develop Aug 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zalexki zalexki deleted the zalexki:patch-1 branch Aug 13, 2019
@matks matks added this to the 1.7.7.0 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.