Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria-label instead of sr-only hidden span in variant-links #15083

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@pojebunny
Copy link
Contributor

commented Aug 12, 2019

Questions Answers
Branch? develop
Description? Small tweak for variant-links.tpl
Type? refacto
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Use screen reader on the site

This change is Reviewable

@pojebunny pojebunny requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 12, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

Hello @pojebunny!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@sarahdib

This comment has been minimized.

Copy link

commented Aug 20, 2019

Hello @pojebunny
Thanks for your contribution.

Can you explain more how to test ? Like what is the resultat we expect ?

Thank you

@pojebunny

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

No real change is expected.
Before screen readers were expected to read the hidden span that could potentially disrupt pages flow / styling.
By replacing the hidden span with aria-label we avoid such problems and gain consistency.

If you want to 'test' that, you can use a screen reader on both versions of the file and see if they are read the same. There is no styling, nor scrypting attached to the hidden span that is removed.

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Thank you @pojebunny

@matks matks merged commit 61ed4fd into PrestaShop:develop Aug 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@OneDotIT OneDotIT referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.