Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Github checks for PHP 5.6 #15127

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@eternoendless
Copy link
Member

commented Aug 16, 2019

Questions Answers
Branch? develop
Description? Removed invalid check for PHP 5.6 syntax, because that version is no longer supported
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Checks pass

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.7.0 milestone Aug 16, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 16, 2019
Copy link
Contributor

left a comment

LGTM

@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Thank you @eternoendless

@matks matks merged commit 8c8b7a7 into PrestaShop:develop Aug 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.