Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed permanent redirection in installer #15131

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@mickaelandrieu
Copy link
Member

commented Aug 16, 2019

Questions Answers
Branch? develop
Description? I've detected permanent redirection on an HTTP call to one of our internal service.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
How to test? Open developer tools in your favorite web browser and start a new installation of PrestaShop. In each step, you can confirm that no 301 HTTP calls are done.

Before

before

After

after


This change is Reviewable

@mickaelandrieu mickaelandrieu requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 16, 2019
Copy link
Contributor

left a comment

LGTM

@sarahdib sarahdib self-assigned this Aug 19, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 19, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Aug 19, 2019
@PierreRambaud PierreRambaud merged commit 8441449 into develop Aug 19, 2019
4 checks passed
4 checks passed
PHP 7.2 Syntax check PHP 7.2 Syntax check
Details
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Thanks @mickaelandrieu but next time, please use your fork instead 😉

@PierreRambaud PierreRambaud deleted the install/fix-permanent-redirection branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.