Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract service declaration #15132

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@eternoendless
Copy link
Member

commented Aug 16, 2019

Questions Answers
Branch? 1.7.6.x
Description? There were to services based on abstract classes which were missing the "abstract" annotation
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? nothing to test

kudos to @mickaelandrieu for pointing it out


This change is Reviewable

@eternoendless eternoendless added this to the 1.7.6.1 milestone Aug 16, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 16, 2019
@matks
matks approved these changes Aug 16, 2019
@PierreRambaud PierreRambaud merged commit 1522324 into PrestaShop:1.7.6.x Aug 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.