Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make module and email translations work again when using a theme other than classic #15139
There was much confusion between the "selected" element (a module name when translating modules, a theme name when translating themes) and the selected theme. Up until now, it was half-managed by request parameters, half-forced to the current theme.
This change clarifies things a little:
Regarding #14809, we'll have to discuss changes in how Mail translations are managed so that email translations work like modules (where
If I've well understood, this introduces is a regression to fix a bug, right?
I removed the unused method and rebased.
Yes and no. It made no sense, it was counterintuitive, and in the end, it didn't work. It's a regression in the same way as fixing a bug is a regression: "But I liked that bug, put it back!"
The system has to be rethought, and in most importantly... specified.