Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All BO classes should inherit from BObasePage #15151

Merged
merged 3 commits into from Aug 19, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Aug 19, 2019

Questions Answers
Branch? develop
Description? All BO classes should inherit from BObasePage
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? npm run smoke-tests

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Aug 19, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Aug 19, 2019
@boubkerbribri boubkerbribri requested a review from SimonGrn Aug 19, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 19, 2019
Copy link
Contributor

left a comment

Thanks ! I don't know why they were still inheriting from CommonPage, that's much better this way

Copy link
Contributor

left a comment

LGTM

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@matthieu-rolland matthieu-rolland merged commit b8bf5bc into PrestaShop:develop Aug 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:InheritanceBOClass branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
5 participants
You can’t perform that action at this time.