Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expect usage in puppeteer tests #15155

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Aug 19, 2019

Questions Answers
Branch? develop
Description? Import expect from chai in each file needed like @PierreRambaud suggested (for better practice
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? URL_FO=Your_Shop_Url npm run smoke-tests

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Aug 19, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Aug 19, 2019
@boubkerbribri boubkerbribri requested a review from PierreRambaud Aug 19, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 19, 2019
@PierreRambaud PierreRambaud merged commit 5bb0a1a into PrestaShop:develop Aug 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

@boubkerbribri boubkerbribri deleted the boubkerbribri:UpdateExpectUsage branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.