Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove another faulty e2e test from Travis #15161

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@matks
Copy link
Contributor

commented Aug 20, 2019

Questions Answers
Branch? develop
Description? Disable another Selenium Guest scenario as it fails randomly
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? #14384
How to test? Travis is green

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 20, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

no more scenario \o/

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

no more scenario \o/

plz hit the "approve" button

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

But if we don't have any more scenario, should be remove travis jobs?

Copy link
Contributor

left a comment

Just a question

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Just a question

Yes and no 😐

Yes:

  • these builds are useless now
  • the code is dead and would be better removed

No:

  • we should replace the broken tests ASAP so the builds should be useful again soon
  • if we keep the builds around, it will "remind" us not to forget about updating them
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

It currently add useless jobs, that are consuming resources.
It's like keeping a commented code to be sure we will not forget to updates it.

We will be able to retrieve travis configuration in the git history 😉

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Removed Travis build too.

Will be reinserted when #14497 is implemented

@matks matks added this to the 1.7.7.0 milestone Aug 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

OK I think Travis lost my build now

Travis 🙄 srsly ? You dont want to be disabled so badly, so you hide the build result ?

@matks matks merged commit 380377f into PrestaShop:develop Aug 21, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks matks deleted the matks:disable-scenario-3 branch Aug 21, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

It's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.