Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker for test AutoUpgrade #15163

Merged
merged 19 commits into from Aug 22, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Aug 20, 2019

Questions Answers
Branch? develop
Description? Separate services in multiple docker-compose files to be capable to use different docker files for differen versions of PS
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? To test upgrade from 1.7.5.2 to 1.7.6.0 :
Cmd1: PS_VERSION_TO_INSTALL=1.7.5.2 docker-compose -f docker-compose.ps-git.yml -f docker-compose.tests.yml up --build
Cmd2: docker-compose -f docker-compose.tests.yml -f docker-compose.ps-git.yml exec -e COMMAND="specific-test" -e PS_VERSION="1.7.6.0" -e TEST_PATH="upgrade/upgradeShop" tests bash /tmp/run-tests.sh

This change is Reviewable

@boubkerbribri boubkerbribri added the WIP label Aug 20, 2019
@boubkerbribri boubkerbribri requested a review from SimonGrn Aug 20, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 20, 2019
@boubkerbribri

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

WIP, please do not merge yet.

@boubkerbribri boubkerbribri added the TE label Aug 20, 2019
@SimonGrn

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Do you think it's possible to change the README as well ?

@boubkerbribri

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Do you think it's possible to change the README as well ?

Yes, I'm doing it (that's why PR is still on WIP)

Copy link
Contributor

left a comment

@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Aug 21, 2019
@boubkerbribri boubkerbribri removed the WIP label Aug 21, 2019
@boubkerbribri

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Please test it before merging it.
Thanks

@matthieu-rolland matthieu-rolland merged commit ad12e4b into PrestaShop:develop Aug 22, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:dockerTestUpgrade branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
5 participants
You can’t perform that action at this time.