Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR has access to all currencies regardless of the current shop #15173
CLDR has access to all currencies regardless of the current shop #15173
Changes from all commits
e767bb7
f6123cd
60b096b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to use ucfirst here and not above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like $this->name has already been set in the constructor using Tools:Ucfirst(). I'm not sure if applying the transformation again in a getter context is overkill or not though... It seems fine to me as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
$this->name
is a string then it means it already has been formatted in the constructor, so no need for an additional ucfirstHowever in
EditCurrencyHandler
the$currency->name
field is filled with an array, which is logical to allow updating the translated fields, but it caused an error whenDefaultCurrencyInMultiShopException
was thrown because the expected string field was then an array, hence this new getterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is useful but not a good idea because of the hidden context (aka the current language being inferred magically).
The proper getter would be
getName($idLang)
where$idLang
cannot be null.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes except that if
$this->name
doesn't contain the array the method may return a string that doesn't match the asked language, which can be confusing..Unless we store the localized names in another field
$this->names
in the constructor, similar to what I had to do in another PR:PrestaShop/classes/Currency.php
Line 223 in 06e1ad1
This would allow to get the name in any language regardless of the context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, you're right. This sucks.