Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .sr-only hidden span to aria-label #15271

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@davidglezz
Copy link
Contributor

commented Aug 27, 2019

Questions Answers
Branch? develop
Description? Its better use aria-label attribute instead of hidden spans, like #15083 . More info https://www.w3.org/TR/WCAG20-TECHS/ARIA14.html
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
How to test? Use screen reader on the site

This change is Reviewable

@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 27, 2019
@sarahdib sarahdib self-assigned this Sep 2, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 2, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 2, 2019
@PierreRambaud PierreRambaud merged commit a309dc0 into PrestaShop:develop Sep 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Thanks @davidglezz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.