Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one column row without colspan #15276

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@davidglezz
Copy link
Contributor

commented Aug 27, 2019

Questions Answers
Branch? develop
Description? All <tr> have 2 <td> except the last one, giving a bad table structure.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Check that the order confirmation table is correctly displayed when the modified row is displayed $subtotals.tax.label !== null

This change is Reviewable

All <tr> have 2 <td> except the last one.
@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 27, 2019
@sarahdib sarahdib added FO QA ✔️ and removed waiting for QA labels Aug 30, 2019
@sarahdib sarahdib self-assigned this Aug 30, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Aug 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Thank you @davidglezz

@matks matks merged commit cd162a2 into PrestaShop:develop Aug 30, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.