Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine two equal adjacent selectors #15277

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@davidglezz
Copy link
Contributor

davidglezz commented Aug 27, 2019

Questions Answers
Branch? develop
Description? avoid CSS overcomplication.
Type? refacto
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? generated CSS after and before the changes are the same

This change is Reviewable

@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 27, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Aug 29, 2019

One more review and merge. No need QA here

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 2, 2020

@NeOMakinG please review 😉

@matks matks requested a review from NeOMakinG Jan 2, 2020
@davidglezz

This comment has been minimized.

Copy link
Contributor Author

davidglezz commented Jan 2, 2020

Should I compile the assets?

@NeOMakinG

This comment has been minimized.

Copy link
Contributor

NeOMakinG commented Jan 3, 2020

I compile these almost everyday, it should be fine ;)

Thanks

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 8, 2020

Closed and reopened for travis :) waiting for CI and merge

@NeOMakinG NeOMakinG merged commit 4be1127 into PrestaShop:develop Jan 10, 2020
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NeOMakinG

This comment has been minimized.

Copy link
Contributor

NeOMakinG commented Jan 10, 2020

Thanks @davidglezz :)

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.