Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to non existent css file #15325

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@eternoendless
Copy link
Member

commented Aug 30, 2019

Questions Answers
Branch? develop
Description? Removed reference to product_page.css that doesn't exist (the contents from the scss file is already included in the main css file).
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Load the product page (in the back-office) in Chrome or equivalent looking at the "network" tab in the developer tools. Without the PR, there's a 404 on product_page.css. With this PR, this file is no longer requested.

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.7.0 milestone Aug 30, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 30, 2019
@matks
matks approved these changes Aug 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Thank you @eternoendless

@matks matks merged commit e59fb14 into PrestaShop:develop Sep 2, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.