Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing title attribute on product page #15326



Copy link

commented Aug 30, 2019

Questions Answers
Branch? develop
Description? Missing title attribute
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15308
How to test?

This change is Reviewable

This reverts commit 81076b6.

This comment has been minimized.

Copy link

commented Aug 30, 2019

Hello @dineshbadrukhiya!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added the Bug label Aug 30, 2019
This reverts commit 67f0139.
@dineshbadrukhiya dineshbadrukhiya requested a review from PrestaShop/prestashop-core-developers as a code owner Aug 30, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

Reverted commit 81076b6 by mistake :) You can merge 81076b6 to fix it.

@PierreRambaud PierreRambaud changed the title Missing title attribute Missing title attribute on product page Aug 30, 2019
@sarahdib sarahdib self-assigned this Sep 2, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 2, 2019
@sarahdib sarahdib added this to the milestone Sep 2, 2019
@Progi1984 Progi1984 merged commit 5347c4f into PrestaShop:develop Sep 2, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
continuous-integration/travis-ci/pr The Travis CI build passed
@dineshbadrukhiya dineshbadrukhiya deleted the dineshbadrukhiya:misssing-title-attribute branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.