Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prestashop/ps_emailsubscription to 2.5.0, prestashop/ps_facetedsearch to 3.2.1, prestashop/ps_contactinfo to 3.2.0 #15354

Merged
merged 5 commits into from Sep 5, 2019

Conversation

@Progi1984
Copy link
Contributor

commented Sep 2, 2019

Questions Answers
Branch? develop
Description? Updated prestashop/ps_emailsubscription to 2.5.0
Updated prestashop/ps_facetedsearch to 3.2.1
Updated prestashop/ps_contactinfo to 3.2.0
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9907
How to test?

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 2, 2019
@Progi1984 Progi1984 changed the title Updated prestashop/ps_emailsubscription to 2.5.0 Updated prestashop/ps_emailsubscription to 2.5.0, prestashop/ps_facetedsearch to 3.2.1, prestashop/ps_contactinfo to 3.2.0 Sep 2, 2019
Copy link
Contributor

left a comment

Thanx @Progi1984 !

Copy link
Contributor

left a comment

composer.json needs to be updated too.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@PierreRambaud Why ? Composer.json is correct :

        "prestashop/ps_contactinfo": "^3",
        "prestashop/ps_emailsubscription": "^2",
        "prestashop/ps_facetedsearch": "^3",
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Not really, PrestaShop's not working if we use the current version of our modules :)

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@PierreRambaud It's why we update the composer.lock. Composer install will base on this file.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@Progi1984 But the first thing you check when you want to know which version you're using is the composer.json.
If the app isn't working anymore with an old version of a module, we must also update the composer.json. Otherwise it's like having ">0" everywhere and only trust the composer.lock.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@PierreRambaud @matthieu-rolland It should be better :)

composer.json Outdated Show resolved Hide resolved
@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@PierreRambaud Corrected

@pierreloicq

This comment has been minimized.

Copy link

commented Sep 4, 2019

Hi,
I am unsure how it relates to this PR, but at the moment, the upgrade proposed for ps_emailsubscription on 1.7.6.1 lead to something buggy on classic theme: e-mail is not saved in the db, and there is no "well received" message.
Thanks

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@pierreloicq Which version of ps_emailsubscription do you have ?

@pierreloicq

This comment has been minimized.

Copy link

commented Sep 5, 2019

@Progi1984 2.3 provided with PS 1.7.61. was working fine, then I upgraded to 2.5 which is buggy

@sarahdib

This comment has been minimized.

Copy link

commented Sep 5, 2019

Hello @pierreloicq

Thank you for your feed back.

I just test (twice) the module email_subscription and it's working for me the email is saved and I receive the email for confirmation.

In the module configuration did you enable the option "send a confirmation email" ?

Have a nice day :)

@pierreloicq

This comment has been minimized.

Copy link

commented Sep 5, 2019

@sarahdib No I did not enable it(I was talking about the message in green that appears below the e-mail box after you submit). But if I activated it, I receive nothing.
Actually I have an error popping up when I go on the module config page :

Notice on line 74 in file C:\\Program Files (x86)\\Ampps\\www\\presta17\\src\\Adapter\\Routing\\LegacyHelperLinkBuilder.php
[8] Undefined index: id_merged
@Progi1984

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@pierreloicq Thanks for your feedback. Could you create a specific issue for this ? Thanks.

@pierreloicq

This comment has been minimized.

Copy link

commented Sep 5, 2019

Here it is
#15425

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 5, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 5, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Thank you @Progi1984

@matks matks merged commit 1f9c443 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue9907 branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.