Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb SEO #15368

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@davidglezz
Copy link
Contributor

commented Sep 2, 2019

Questions Answers
Branch? develop
Description? The PullRequest #14710 causes structured data to no longer be valid.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13083 (Already closed) & #15368
How to test? Go to any page having a breadcrumb in front office (category, product, etc), and check that the last breadcrumb element is not clickable. In addition, Check structured data with the Google tool https://search.google.com/structured-data/testing-tool

FIXED ERROR:
image


This change is Reviewable

The PullRequest #14710 causes structured data to no longer be valid.
@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 2, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Sep 2, 2019
@sarahdib

This comment has been minimized.

Copy link

commented Sep 3, 2019

Hello @davidglezz

Thank you for this contribution.

It's ok for me :
image

Best regards

@sarahdib sarahdib added QA ✔️ FO and removed waiting for QA labels Sep 3, 2019
@Progi1984 Progi1984 merged commit 6f38d7e into PrestaShop:develop Sep 3, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sarahdib sarahdib referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.