Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless and buggy identifier computation #15382

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Sep 3, 2019

Questions Answers
Branch? 1.7.6.x
Description? The new LegacyHelperLinkBuilder (introduced in #14721) causes an error warning when the expected parameter was not present, besides this computation was useless as it expected the parameter to be present
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15333 and fixes #15318
How to test? You can check the fix by using the product comments module or ps_emailsubscription module (known bugs, but probably other modules had troubles). You also need to check that the quick search is still valid

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 3, 2019
@jolelievre jolelievre added this to the 1.7.6.1 milestone Sep 3, 2019
@MathiasReker

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Milestone should be 1.7.6.2 instead of 1.7.6.1?

@eternoendless eternoendless reopened this Sep 17, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 17, 2019
@sarahdib sarahdib modified the milestones: 1.7.7.0, 1.7.6.2 Sep 17, 2019
@matks matks closed this Sep 19, 2019
@matks matks reopened this Sep 19, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Thank you @jolelievre

@matks matks merged commit dd1c3c3 into PrestaShop:1.7.6.x Sep 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@jolelievre jolelievre deleted the jolelievre:fix-helper-list branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.