Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape Employee email in avatar block #15397

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Sep 4, 2019

Questions Answers
Branch? develop
Description? The employee email value must be escaped.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Make sure the mail is still displayed
image

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 4, 2019
@matks
matks approved these changes Sep 4, 2019
@matks matks added the waiting for QA label Sep 4, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 4, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 4, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Thank you @PierreRambaud

@matks matks merged commit 0f95061 into PrestaShop:develop Sep 4, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/unescape-value branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.