Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug keeping users from choosing a carrier before cart order completion #15399

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

commented Sep 4, 2019

  • Update current cart's id_address_devivery when the update of an address resulted in the creation of a new address (hence changing the address id)
Questions Answers
Branch? develop
Description? Fix bug that kept user from choosing a carrier
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9932
How to test? See issue #9932, and check that you can choose a carrier once you've completed all the reproduction steps.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 4, 2019
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:fix-no-carriers branch 2 times, most recently from c173e95 to ad7d07f Sep 4, 2019
- Update current cart's id_address_devivery when the update of an address resulted in the creation of a new address (hence changing the address id)
@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:fix-no-carriers branch from ad7d07f to 87f351e Sep 4, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Sep 4, 2019
@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Hi @matthieu-rolland,

Following these steps:

  1. Go to FO
  2. Create a new customer
  3. add some products to the cart => process to the checkout page
  4. Add new address
  5. Click several times on the continue button

"Unfortunately, there are no carriers available for your delivery address." is displayed
https://drive.google.com/file/d/1q-SvCj9mSb-BCxe3PA1p4NaWtvZzHZsZ/view

Thanks!

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Hi @matthieu-rolland,

Following these steps:

  1. Go to FO
  2. Create a new customer
  3. add some products to the cart => process to the checkout page
  4. Add new address
  5. Click several times on the continue button

"Unfortunately, there are no carriers available for your delivery address." is displayed
https://drive.google.com/file/d/1q-SvCj9mSb-BCxe3PA1p4NaWtvZzHZsZ/view

Thanks!

@thank you for your feedback @khouloudbelguith

My pr is not fixing this bug, but this one that you reproduced here:

https://drive.google.com/file/d/1hKq1Naj_5rXv6EvLT94XfldME7eSLsAf/view

It is not the issue of clicking several times on "continue" but the issue we have when editing an address that was already linked to a previous order, then we have no carriers. The consequence is the same but it's not the same bug.

It's this issue: #9932

@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Thank you @matthieu-rolland

@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Closing and reopening PR to reset Travis status

@matks matks closed this Sep 18, 2019
@matks matks reopened this Sep 18, 2019
@matthieu-rolland matthieu-rolland merged commit ef9257a into PrestaShop:develop Sep 19, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.