Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postal Code of South Korea #15404

Merged

Conversation

@khouloudbelguith
Copy link
Contributor

commented Sep 4, 2019

Questions Answers
Branch? develop
Description? the zip code of South Korea gets changed.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15254
How to test? After re-install, access to BO->Localization->Countries, then click on the "edit" button of South Korea, you will see the zip code format is "NNNNN" (and not the old format "NNN-NNN"). FO, try to add a new address in South Korea, set 11230 as zip code (the zip code of Gangnam city). The field will be validated.

This change is Reviewable

@khouloudbelguith khouloudbelguith requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 4, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 5, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 5, 2019
@sarahdib sarahdib self-assigned this Sep 5, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Thank you @khouloudbelguith

@matks matks merged commit 5e46014 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.