Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing esLint errors in project #15415

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Sep 5, 2019

Questions Answers
Branch? develop
Description? Fixing all errors showed with eslint
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? npm run lint to see that all errors are fixed

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Sep 5, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 5, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 5, 2019
Copy link
Contributor

left a comment

lgtm (as seen with @boubkerbribri , @SimonGrn 's comment is dealt with)

@matthieu-rolland matthieu-rolland merged commit 4d07499 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:fixLintErrors branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.