Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart FO tests with puppeteer - Sanity tests campaign #15421

Merged

Conversation

@nesrineabdmouleh
Copy link
Contributor

commented Sep 5, 2019

Questions Answers
Branch? develop
Description? Adding sanity tests cart FO
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="sanity/cartFO" URL_FO=SHOP_URL npm run specific-test

This change is Reviewable

@nesrineabdmouleh nesrineabdmouleh requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 5, 2019
@boubkerbribri boubkerbribri added the WIP label Sep 5, 2019
Copy link
Contributor

left a comment

Thanks @nesrineabdmouleh

tests/puppeteer/pages/commonPage.js Outdated Show resolved Hide resolved
@boubkerbribri boubkerbribri added the TE label Sep 5, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 5, 2019
@nesrineabdmouleh nesrineabdmouleh force-pushed the nesrineabdmouleh:sanity_tests_cart_fo branch from 1145b70 to a3fb682 Sep 6, 2019
@boubkerbribri boubkerbribri removed the WIP label Sep 6, 2019
@nesrineabdmouleh nesrineabdmouleh force-pushed the nesrineabdmouleh:sanity_tests_cart_fo branch from a3fb682 to ca43db3 Sep 9, 2019
nesrine abdmouleh
Copy link
Contributor

left a comment

lgtm

@matthieu-rolland matthieu-rolland merged commit 98d92c6 into PrestaShop:develop Sep 9, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
5 participants
You can’t perform that action at this time.