Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license headers 177 #15426

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@matks
Copy link
Contributor

commented Sep 5, 2019

Questions Answers
Branch? develop
Description? Fix license headers and update command
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15116
How to test? Nothing to test

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 5, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

Here is the list of files for which the diff shows more than 1 add / 1 remove:

0	24	admin-dev/themes/new-theme/.webpack/common.js
6	6	admin-dev/themes/new-theme/js/app/cldr/exception/localization.js
6	6	admin-dev/themes/new-theme/js/app/cldr/index.js
6	6	admin-dev/themes/new-theme/js/app/cldr/number-formatter.js
6	6	admin-dev/themes/new-theme/js/app/cldr/number-symbol.js
6	6	admin-dev/themes/new-theme/js/app/cldr/specifications/number.js
6	6	admin-dev/themes/new-theme/js/app/cldr/specifications/price.js
3	3	admin-dev/themes/new-theme/js/pages/error/index.js
0	24	admin-dev/themes/new-theme/tests/cldr/number-formatter.spec.js
0	24	admin-dev/themes/new-theme/tests/cldr/number-symbol.spec.js
0	24	admin-dev/themes/new-theme/tests/cldr/specifications/number.spec.js
0	24	admin-dev/themes/new-theme/tests/cldr/specifications/price.spec.js
3	3	app/Resources/TwigBundle/views/Exception/error.html.twig
3	3	src/Adapter/Configuration/CommandHandler/SwitchDebugModeHandler.php
3	3	src/Core/Domain/Configuration/Command/SwitchDebugModeCommand.php
3	3	src/Core/Domain/Configuration/CommandHandler/SwitchDebugModeHandlerInterface.php
0	25	src/Core/Domain/Theme/Exception/FailedToEnableThemeModuleException.php
5	7	src/PrestaShopBundle/Command/UpdateLicensesCommand.php
3	3	src/PrestaShopBundle/Controller/Admin/ErrorController.php
0	25	src/PrestaShopBundle/Form/Admin/Type/IntegerMinMaxFilterType.php
0	25	src/PrestaShopBundle/Form/Admin/Type/NumberMinMaxFilterType.php
3	3	src/PrestaShopBundle/Resources/views/Admin/Exception/error.html.twig
23	23	src/PrestaShopBundle/Resources/views/Admin/Improve/Design/Cms/Blocks/form.html.twig
23	23	src/PrestaShopBundle/Resources/views/Admin/Product/ProductPage/Blocks/footer.html.twig
3	3	src/PrestaShopBundle/Resources/views/Admin/Sell/Customer/Blocks/showcase_card.html.twig
26	1	tests-legacy/bootstrap.php
0	25	tests/Unit/Adapter/Hook/HookDispatcherTest.php
0	24	tests/Unit/PrestaShopBundle/Twig/Fixtures/modules/template.html.twig
0	24	tests/Unit/Resources/mails/templates/account.html.twig
0	24	themes/classic/templates/catalog/_partials/variant-links.tpl

For every other changed file, the only modif is
* 2007-2019 PrestaShop and Contributors
=>
* 2007-2019 PrestaShop SA and Contributors

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

In order to compute the list, I did:

  $ git diff HEAD HEAD^  --numstat > log.txt
  // modifies '1  1  ' to 'aaa' in log.txt
  $ sed '/^aaa/d' log.txt > log2.txt
@matks

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@Progi1984 Waiting for review 😉

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@PierreRambaud do you think we need QA ? I think not

@matks matks added this to the 1.7.7.0 milestone Sep 5, 2019
@PierreRambaud PierreRambaud merged commit 33684a3 into PrestaShop:develop Sep 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

No need QA for headers license :) Thanks @matks

@matks matks referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.