Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable port in shop domains #15447

Merged

Conversation

@matks
Copy link
Contributor

commented Sep 6, 2019

Questions Answers
Branch? develop
Description? Since #14089 was merged, you cannot use mysite:myportnumber (with a not-default port number) as a domain name although this can be useful. This PR re-enabled this as a fallback. The fact it is used as a fallback should make sure #14089 bugfix is still valid.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Install a shop using a not-standard port such as 8888 (default MAMP port) (so your domain should be localhost:8888 and try to install and reach the FO.

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 6, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Seems legit! Nice catch @matks

@khouloudbelguith khouloudbelguith added this to the 1.7.7.0 milestone Sep 11, 2019
@PierreRambaud PierreRambaud merged commit 7a91efe into PrestaShop:develop Sep 11, 2019
4 checks passed
4 checks passed
PHP 7.2 Syntax check PHP 7.2 Syntax check
Details
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.