Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated blockReassurance in composer.json #15501

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Sep 11, 2019

Questions Answers
Branch? develop
Description? If we install the blockReassurance module from module, the version 3.x is installed
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Relative to #14700
How to test? If we install the blockReassurance module from module, the version 4.1.1 is installed

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 11, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Sep 11, 2019

Does this one need a specific version of blockreassurance module?

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Sep 12, 2019

IMO this PR should also include the new version of the module in composer

@Progi1984 Progi1984 added WIP and removed waiting for QA labels Sep 12, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Sep 12, 2019

@eternoendless I do it :)

@Progi1984 Progi1984 closed this Sep 27, 2019
@Progi1984 Progi1984 reopened this Sep 27, 2019
@Progi1984 Progi1984 dismissed stale reviews from jolelievre and PierreRambaud via 1ba91dd Oct 8, 2019
@Progi1984 Progi1984 force-pushed the Progi1984:issue14700 branch from d11f80e to 1ba91dd Oct 8, 2019
composer.json Outdated Show resolved Hide resolved
@Progi1984 Progi1984 force-pushed the Progi1984:issue14700 branch from 1ba91dd to 2ce0a54 Oct 8, 2019
@Progi1984 Progi1984 removed the WIP label Oct 8, 2019
@Progi1984 Progi1984 requested review from jolelievre, PierreRambaud and PrestaShop/prestashop-core-developers Oct 8, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Oct 8, 2019
@Progi1984 Progi1984 force-pushed the Progi1984:issue14700 branch from 2ce0a54 to 55cfe49 Oct 9, 2019
@Progi1984 Progi1984 changed the title Updated hooks for blockReassurance in Classic Theme Updated blockReassurance in composer.json Oct 10, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 10, 2019

Thank you @Progi1984

@matks matks merged commit 3074bbb into PrestaShop:develop Oct 10, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue14700 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.