Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to avoid duplicate invoice line. #15514

Conversation

@FlorentinGarnier
Copy link

FlorentinGarnier commented Sep 12, 2019

Questions Answers
Branch? develop
Description? The method Order::setCurrentState() add new line for invoice in order view
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15513 and maybe #11154
How to test? Set an orderstate by webservice

This change is Reviewable

@FlorentinGarnier FlorentinGarnier requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 12, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Sep 12, 2019

Hello @FlorentinGarnier!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@FlorentinGarnier

This comment has been minimized.

Copy link
Author

FlorentinGarnier commented Sep 12, 2019

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Sep 18, 2019

Hello @FlorentinGarnier

Thank you for this contribution.
Can you provide us a demo module to test this PR?

Have a nice day

@FlorentinGarnier

This comment has been minimized.

Copy link
Author

FlorentinGarnier commented Sep 25, 2019

Hello @sarahdib,
You can do this for testing this PR

Best regard

Describe the bug
When update the order with Order::setCurrentState() create a new line in payments for create the invoice.

To Reproduce
Update state with webservice

[Edited by Khouloud]

Steps to reproduce the issue:

  1. Edit the status "Payment accepted" as described in the screenshot
    image
  2. Create a new order, the first status created is "Payment accepted" [you can create an order from the BO or you can use a Paypal module]
  3. Install the module
    fgorderstate.zip
  4. Click on Configure => click on the link & edit the order_id
  5. Go the BO => Orders => previous Order created => error => new payment line added => wrong
    image
@FlorentinGarnier

This comment has been minimized.

Copy link
Author

FlorentinGarnier commented Oct 3, 2019

Hello, do you have take into account my last comment ?

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 7, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 7, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 8, 2019

Closing and re-opening to reset Travis

@matks matks closed this Oct 8, 2019
@matks matks reopened this Oct 8, 2019
@matks
matks approved these changes Oct 8, 2019
@PierreRambaud PierreRambaud merged commit 7170a5f into PrestaShop:develop Oct 8, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.