Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Close browser after each scenario #15519

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Sep 13, 2019

Questions Answers
Branch? develop
Description? Browser didn't close if multiple tests were launched (Headfull mode)
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? HEADLESS=false TEST_PATH="sanity/productsBO/*" URL_FO=SHOP_URL npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Sep 13, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 13, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 13, 2019
Copy link
Contributor

left a comment

lgtm

@SimonGrn SimonGrn merged commit d1bb3d3 into PrestaShop:develop Sep 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SimonGrn

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Thanks guys

@boubkerbribri boubkerbribri deleted the boubkerbribri:afterScenario branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.