Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO : Bad combination dropdown in cart rule #15546

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@idnovate
Copy link
Contributor

commented Sep 16, 2019

When you load a cart rule with a gift product and the gift product search found more than 1 product, all the combination dropdowns are visible.

Questions Answers
Branch? develop
Description? When you load a cart rule with a gift product and the gift product search found more than 1 product, all the combination dropdowns are visible.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15529
How to test? Create a product with name and reference "AAA" with 2 combinations. Create a product with name and reference "AAAA" with 2 combinations. Create a cart rule with "AAA" as gift product. Save the rule. Edit again the cart rule and you will see 2 dropdowns, one with "AAA" combinations and another with "AAAA" combinations.

This change is Reviewable

When you load a cart rule with a gift product and the gift product search found more than 1 product, all the combination dropdowns are visible.
@idnovate idnovate requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 16, 2019
@khouloudbelguith

This comment has been minimized.

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Sep 17, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Closing and re-opening the PR to re-start Travis as we have migrated from travis-ci.org to travis-ci.com and this PR got lost in the migration (apparently)

@matks matks closed this Sep 17, 2019
@matks matks reopened this Sep 17, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Thank you @idnovate

@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Travis is happy 🎶

@matks matks merged commit 768ae52 into PrestaShop:develop Sep 17, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.