Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update php docs on currency class #15551

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@zalexki
Copy link
Contributor

commented Sep 16, 2019

Questions Answers
Branch? develop
Description? update php docs for currency class
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Use phpstan lvl 5

This change is Reviewable

@zalexki zalexki requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Closing and reopening for travis reset

@matks matks closed this Sep 20, 2019
@matks matks reopened this Sep 20, 2019
@matks
matks approved these changes Sep 20, 2019
@PierreRambaud PierreRambaud merged commit fb61443 into PrestaShop:develop Sep 21, 2019
3 of 4 checks passed
3 of 4 checks passed
code-review/reviewable 1 file left
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2019

Thanks @zalexki

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.