Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mocha scenario and test with describe and it functions #15584

Merged
merged 4 commits into from Sep 20, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Sep 17, 2019

Questions Answers
Branch? develop
Description? Delete scenario and test and replace it with mocha functions describe and it
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? URL_FO=SHOP_URL npm run sanity-tests

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Sep 17, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 17, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 17, 2019
@SimonGrn SimonGrn requested review from matks, PierreRambaud and Progi1984 Sep 18, 2019
@matks
matks approved these changes Sep 20, 2019
@SimonGrn SimonGrn merged commit 3f78797 into PrestaShop:develop Sep 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:describeItMocha branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.