Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selenium tests #15590

Merged
merged 3 commits into from Sep 18, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Sep 18, 2019

Questions Answers
Branch? 1.7.6.x
Description? Disable old selenium tests that are always failing and will be removed anyway.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? Tests should be green.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 18, 2019
@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.6.x Sep 18, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:remove-selenium-tests branch 17 times, most recently from f15a9db to d15e6d2 Sep 18, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:remove-selenium-tests branch from d15e6d2 to afbc4dd Sep 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

You the MVP @PierreRambaud

@matks matks added this to the 1.7.6.2 milestone Sep 18, 2019
@matks
matks approved these changes Sep 18, 2019
@@ -35,7 +35,7 @@
"parsed-url": "0.0.0",
"q": "^1.4",
"req": "^0.1",
"selenium-standalone": "^6.14.0",
"selenium-standalone": "^6.16",

This comment has been minimized.

Copy link
@mickaelandrieu

mickaelandrieu Sep 18, 2019

Member

why do we need selenium if we remove the selenium test suite ?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Sep 18, 2019

Author Contributor

Selenium is still needed to run our tests under tests/E2E. We only remove tests/Selenium

@@ -16,7 +16,7 @@ global.URL = siteUrl;
global.install_language = argv.LANGUAGE || 'en';
global.install_country = argv.COUNTRY || 'france';
global.country_currency = argv.CURRENCY || 'EUR';
global.db_server = argv.DB_SERVER || 'lolcahost';
global.db_server = argv.DB_SERVER || 'localhost';

This comment has been minimized.

Copy link
@mickaelandrieu
@matks matks merged commit 467a3c3 into PrestaShop:1.7.6.x Sep 18, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:remove-selenium-tests branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.