Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix lang table multi-store data issue" #15621

Merged
merged 4 commits into from Oct 10, 2019

Conversation

@matks
Copy link
Contributor

matks commented Sep 19, 2019

Questions Answers
Branch? 1.7.6.x
Description? Reverts #11876 as it seems to have introduced major regression #15274
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15274
How to test? See ticket

This change is Reviewable

matks added 2 commits Sep 19, 2019
This reverts commit dc6ed1c.
This reverts commit b84d99d.
@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 19, 2019
Copy link
Contributor

PierreRambaud left a comment

If we revert this change, we must add an upgrade script to insert _lang values

Copy link
Contributor

jolelievre left a comment

I don't understand everything in your query :D

@PierreRambaud PierreRambaud dismissed their stale review Sep 25, 2019

Add some commits, cannot review anymore

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Sep 25, 2019

@matks should we reopen the issue fixed by #11876 ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Sep 25, 2019

@marionf I don't think because it was the legacy behaviour and afaik it's mandatory to have all language saved in database :/

Copy link
Contributor

jolelievre left a comment

@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Oct 7, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 10, 2019
@PierreRambaud PierreRambaud merged commit 516f493 into PrestaShop:1.7.6.x Oct 10, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 10, 2019

Thanks @matks

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 10, 2019

@marionf I don't think because it was the legacy behaviour and afaik it's mandatory to have all language saved in database :/

So you think that #11876 is harmless and actually expected ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 10, 2019

@matks After reading how the ObjectModel works with language, yes it was the expected behavior..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.