Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly cleanup the customization table if no more customized_data #15625

Merged
merged 2 commits into from Sep 20, 2019

Conversation

@jocel1
Copy link
Contributor

commented Sep 20, 2019

Questions Answers
Branch? develop
Description? Properly cleanup the customization table when customized_data is deleted
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #15624
How to test? Add a customization to a product, remove the customization, put the product into your cart. Without the fix, you'll not be able to remove the product from the cart because will still have an id_customization associated, but no more customized_data

This change is Reviewable

@jocel1 jocel1 requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 20, 2019
@jocel1 jocel1 force-pushed the jocel1:fix-customization-removal branch from 68b5a5d to 2278b34 Sep 20, 2019
@khouloudbelguith khouloudbelguith added this to the 1.7.7.0 milestone Sep 20, 2019
@matks matks changed the title properly cleanup the customization table if there's no more customized_data Properly cleanup the customization table if no more customized_data Sep 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Thank you @jocel1 😉

@matks matks merged commit cf77ee9 into PrestaShop:develop Sep 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.