Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving login test in a commonTests directory #15630

Merged
merged 10 commits into from Sep 20, 2019

Conversation

@boubkerbribri
Copy link
Contributor

commented Sep 20, 2019

Questions Answers
Branch? develop
Description? Adding commonTests directory with login test as an example, and create PageObjects var to be detected in mocha context
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="sanity/02_productsBO/01_filterProducts" URL_FO=SHOP_URL npm run specific-test

This change is Reviewable

Copy link
Contributor

left a comment

Thanks

tests/puppeteer/.eslintrc.js Show resolved Hide resolved
@boubkerbribri boubkerbribri force-pushed the boubkerbribri:commonTestLogin branch from 9c3f706 to 2e1272d Sep 20, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Sep 20, 2019
@boubkerbribri boubkerbribri removed the WIP label Sep 20, 2019
@boubkerbribri boubkerbribri marked this pull request as ready for review Sep 20, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 20, 2019
Copy link
Contributor

left a comment

Thanks

@SimonGrn SimonGrn merged commit 76ba692 into PrestaShop:develop Sep 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:commonTestLogin branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.