Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb category #15642

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@jocel1
Copy link
Contributor

commented Sep 22, 2019

Questions Answers
Branch? develop
Description? Breadcrumb computation is wrong on home category
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #15641
How to test? Go on the home category, and check breadcrumb is the source. It should only contains 1 entry + "count":1. Without the fix it generates invalid breadcrumb, which could be annoying when using google rich snippets

This change is Reviewable

@jocel1 jocel1 requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 22, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Sep 23, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 25, 2019
@PierreRambaud PierreRambaud merged commit 3024a16 into PrestaShop:develop Sep 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.