Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty legacy action parameter #15658

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@jolelievre
Copy link
Contributor

commented Sep 23, 2019

Questions Answers
Branch? 1.7.6.x
Description? When building legacy urls the action needs to remain empty. The previous used value (1 or true) didn't work because in some modules check that the parameter is present AND that it's empty
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #15559
How to test? See the video in the issue, try to edit a link in ps_mainmenu module without this PR the module shows you a form to edit but can't handle it

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.2 milestone Sep 23, 2019
@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 23, 2019
@jolelievre jolelievre force-pushed the jolelievre:empty-legacy-action branch from 1d8ad74 to cd253d6 Sep 23, 2019
@jolelievre jolelievre force-pushed the jolelievre:empty-legacy-action branch from cd253d6 to 1b8ee84 Sep 23, 2019
@jolelievre jolelievre changed the base branch from develop to 1.7.6.x Sep 25, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 26, 2019
@sarahdib

This comment has been minimized.

@PierreRambaud PierreRambaud merged commit bba5b39 into PrestaShop:1.7.6.x Sep 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Thanks @jolelievre

@jolelievre jolelievre deleted the jolelievre:empty-legacy-action branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.