Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong selector expression, unable to move parent category #15665

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@PierreRambaud
Copy link
Contributor

commented Sep 24, 2019

Questions Answers
Branch? 1.7.6.x
Description? The css expression is currently broken for the defaultTitle.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15344
How to test? You shouldn't have error on Safari and should be able to move parent category.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Sep 24, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Sep 24, 2019
Copy link
Contributor

left a comment

lgtm

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 25, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Pull request still in queue but everything is ok https://travis-ci.com/PrestaShop/PrestaShop/builds/128877882 🤔

@jolelievre jolelievre closed this Sep 26, 2019
@jolelievre jolelievre reopened this Sep 26, 2019
@jolelievre

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

I closed/reopened it to relaunch the build, let's wait for it!

@matks
matks approved these changes Sep 27, 2019
@toutantic toutantic merged commit e12776f into PrestaShop:1.7.6.x Sep 27, 2019
2 of 3 checks passed
2 of 3 checks passed
Travis CI - Pull Request Build Created
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/15344 branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.