Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rage clicking on checkout steps submit button #15710

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@rdy4ever
Copy link
Contributor

commented Sep 26, 2019

Questions Answers
Branch? develop
Description? This PR fixes fixes #15703. Issue reproduced in this comment. Coluld've done this in classic, but done it in core so other themes may benefit from the fix
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #15703
How to test? Go to checkout and click like a crazy person on the continue button on each step. With this PR, the button will be disabled after first click.

This change is Reviewable

@PierreRambaud PierreRambaud force-pushed the rdy4ever:handle_rage_click_checkout branch from 3a1bb66 to cfb57a7 Sep 27, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

I squash your commits, LGTM.

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Sep 27, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Sep 27, 2019
@matks

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

Thank you @rdy4ever

@matks matks merged commit 5ef5f74 into PrestaShop:develop Sep 27, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@rdy4ever rdy4ever deleted the rdy4ever:handle_rage_click_checkout branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.