Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Association of payment methods with delivery module #15799

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@Seleda
Copy link
Contributor

Seleda commented Oct 2, 2019

Questions Answers
Branch? develop
Description? if you install a delivery module and then install a payment module, the new payment method will not contact that delivery module.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15852
How to test? Default $modules_filters is only carriers, not modules

This change is Reviewable

@Seleda Seleda requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 2, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

matthieu-rolland commented Oct 3, 2019

Thank you for your contribution @Seleda !

Could you please create an issue explaining what you are fixing?
Or if an issue already exists, link it in the PR description?

Thanx !

@Seleda

This comment has been minimized.

Copy link
Contributor Author

Seleda commented Oct 3, 2019

During installation, payment module are associate with delivery. (table module_carrier)Currently, payment module are not associate with delivery if delivery is a module. If you select this delivery on order page, the payment will not appear.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 4, 2019

Sorry @Seleda, we are not the deciders 😅 This is why an issue is required.

@Seleda

This comment has been minimized.

Copy link
Contributor Author

Seleda commented Oct 7, 2019

I thought that was obvious. Need all carriers.

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

matthieu-rolland commented Oct 7, 2019

@Seleda, it's ok, I created the issue : #15852 . ;)

We ask this because it is part of our protocol: it is useful for our product team, it allows them to track what is happening on the project, this is why it is not optional :)

Copy link
Contributor

matthieu-rolland left a comment

Thank you for your contribution @Seleda 👍

@sarahdib sarahdib self-assigned this Oct 9, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 9, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 9, 2019
@PierreRambaud PierreRambaud merged commit 6399636 into PrestaShop:develop Oct 9, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 9, 2019

Thanks @Seleda

@Seleda Seleda deleted the Seleda:fix5 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.