Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces icons instead of dropdown column for Orders page list #15808

Conversation

@tomas862
Copy link
Member

tomas862 commented Oct 3, 2019

Questions Answers
Branch? develop
Description? Adds and aligns icons. See below for visual changes.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? partially #10582
How to test? See below for what has been changed

Screenshot (20)

you can see that the icons are aligned in 3 columns. Before it was only preview and dropdown.

This PR only changes the design and nothing more. Preview button is still not functional as the page not working right now. Rebuild assets to see all changes


This change is Reviewable

@tomas862 tomas862 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 3, 2019
/**
* Allow adding group of links in single column. Specially adapted for order page design case.
*/
final class OrderLinkGroupColumn extends AbstractColumn

This comment has been minimized.

Copy link
@sarjon

sarjon Oct 3, 2019

Contributor

Should it be more generic? It would be nice if we could use it in other grids as well.

This comment has been minimized.

Copy link
@matks

matks Oct 3, 2019

Contributor

Indeed it would be great 🙏

->setRequired([
'links',
])
->setAllowedTypes('links', 'array')

This comment has been minimized.

Copy link
@sarjon

sarjon Oct 3, 2019

Contributor

I think you should validate internal links structure as well.

@matks
matks approved these changes Oct 7, 2019
@matks matks added the waiting for QA label Oct 7, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 8, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 8, 2019

Hi @tomas862 , thanks for the PR !
I'm wondering if the font size is not too small (in "Status" or "Total" column). @TristanLDD , could you take a look ? (see screenshot)

Capture d’écran de 2019-10-08 16-33-12

Thanks !

@sarjon

This comment has been minimized.

Copy link
Contributor

sarjon commented Oct 8, 2019

Hi @Robin-Fischer-PS, this PR does not affect neither "Total" nor "Status" columns, so if font would need to be changed, it should be done in dedicated PR. :) This PR only changes "Actions" column, refer to the description of this PR for more details. 😉

@matthieu-rolland matthieu-rolland merged commit ec4287e into PrestaShop:develop Oct 9, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks removed the waiting for UX label Oct 9, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 9, 2019
@matks matks referenced this pull request Oct 9, 2019
7 of 41 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.