Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm is not anymore in the nodejs package #15847

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 7, 2019

Questions Answers
Branch? 1.7.6.x
Description? Npm is not anymore in the nodejs package.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? No need QA

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Oct 7, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 7, 2019
@matks
matks approved these changes Oct 7, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 8, 2019

Re-running failed travis build for the 3rd time as we get travis error 1) LegacyTests\Integration\PrestaShopBundle\Controller\Api\StockManagementControllerTest::itShouldReturnValidResponseWhenRequestingBulkStockEdition PHPUnit_Framework_Exception: Segmentation fault (core dumped) ...

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 10, 2019

@matks I love this kind of segfault... 😭

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 10, 2019

@matks I love this kind of segfault... 😭

According to Travis, this comes from a combination of php5.6 + phpunit data provider too big

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 10, 2019

@matks Everything's ok now!

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 10, 2019

Thank you @PierreRambaud

@matks matks merged commit 7a8ba35 into PrestaShop:1.7.6.x Oct 10, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.