Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing translation for tax label #15851

Merged

Conversation

@JevgenijVisockij
Copy link

JevgenijVisockij commented Oct 7, 2019

Questions Answers
Branch? develop
Description? Fixed missing translation for tax label
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Do checkout with gift and see that tax incl. /tax excl. is translated

This change is Reviewable

@JevgenijVisockij JevgenijVisockij requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 7, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Oct 7, 2019

Hello @JevgenijVisockij!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 7, 2019

Makes sense 👍waiting for @LouiseBonnard confirmation as she's in charge of translation strings

However it seems you removed the blank space before

@sarjon

This comment has been minimized.

Copy link
Contributor

sarjon commented Oct 7, 2019

However it seems you removed the blank space before

I think it makes sense since formatting below adds space anyway. 🤔

@sarjon
sarjon approved these changes Oct 7, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 7, 2019

However it seems you removed the blank space before

I think it makes sense since formatting below adds space anyway. 🤔

Nice catch !

@matks matks added the waiting for QA label Oct 7, 2019
@sarahdib sarahdib self-assigned this Oct 9, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 9, 2019

hello @JevgenijVisockij

Thank you for your contribution.

I can't find the translation in the back office Shop > Theme > Checkout

@sarjon

This comment has been minimized.

Copy link
Contributor

sarjon commented Oct 10, 2019

@sarahdib I guess because it wasn't there before, text was not translatable before and after this PR, it is.

@matks any ideas how to test it?

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 10, 2019

Hello @JevgenijVisockij

I check with @LouiseBonnard it's ok for us :)

Thank you :)

@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 10, 2019
@sarjon

This comment has been minimized.

Copy link
Contributor

sarjon commented Oct 10, 2019

@matks
matks approved these changes Oct 10, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 10, 2019

@matks :shipit:

Yes sir

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 10, 2019

Thank you @sarjon and @JevgenijVisockij

@matks matks merged commit b2a1777 into PrestaShop:develop Oct 10, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.