Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must use min-with instead max-widght for the Profile button #15856

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 7, 2019

Questions Answers
Branch? 1.7.6.x
Description? Must use min-with instead max-widght for the Profile button and add fit-content property for width.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15734
How to test? Follow ticket instruction.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Oct 7, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 7, 2019
@prestonBot prestonBot added the Bug label Oct 7, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/15734 branch from 8b0a7be to 060a710 Oct 7, 2019
@matthieu-rolland matthieu-rolland requested review from matthieu-rolland and removed request for matthieu-rolland Oct 7, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm, thank you @PierreRambaud

@sarahdib sarahdib self-assigned this Oct 8, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 8, 2019
@sarahdib sarahdib removed their assignment Oct 8, 2019
@prestonBot prestonBot added the 1.7.6.x label Oct 9, 2019
@matthieu-rolland matthieu-rolland merged commit d3c5853 into PrestaShop:1.7.6.x Oct 9, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/15734 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.